Skip to content

Conversation

@masseyke
Copy link
Member

This adds the elasticsearch-specification for GET {index}/_sample and GET {index}/_sample/stats.

@masseyke masseyke added specification compiler skip-backport This pull request should not be backported labels Oct 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2025

Following you can find the validation changes against the target branch for the APIs.

API Status Request Response
indices.get_sample 🟠 → 🟢 Missing type → 2/2 Missing type → 2/2
indices.get_sample_stats 🟠 → 🟢 Missing type → 2/2 Missing type → 2/2

You can validate these APIs yourself by using the make validate target.

@masseyke masseyke requested a review from a team as a code owner October 20, 2025 20:44
delete-query-rule-from-ui,https://www.elastic.co/docs/solutions/search/query-rules-ui#delete-a-rule,,Delete a rule from the Query Rules UI
list-query-rules-in-ui,https://www.elastic.co/docs/solutions/search/query-rules-ui#accessing-the-query-rules-ui,,See rules and rulesets in Query Rules UI
delete-query-ruleset-from-ui,https://www.elastic.co/docs/solutions/search/query-rules-ui#delete-a-ruleset,,Delete a ruleset from the Query Rules UI
random_sample,https://www.elastic.co/guide/en/elasticsearch/reference/{branch}/ingest-random-sampling.html,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this part generated? seems like this isnt a valid url

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry, I copied that pattern from an old PR. It looks like the URLs are different now, so I've made it look more like other ones. Hopefully someone from the docs team can chime in if that's wrong.

Copy link
Contributor

@seanzatzdev seanzatzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment, but if that's correct we can merge this.

* Request for a random sample of raw documents ingested into the given index or data stream.
*
* @rest_spec_name indices.get_sample
* @availability serverless visibility=feature_flag feature_flag=random_sampling since=9.3.0 stability=experimental
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify: this @availability annotation will make this API available in serverless only. It will show up in the clients as not supported for stack unless you also add a stack @availability annotation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh that's definitely not what I want!

@masseyke masseyke merged commit 003b872 into main Oct 21, 2025
8 checks passed
@masseyke masseyke deleted the random-sample branch October 21, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler skip-backport This pull request should not be backported specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants